Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: restyled project ideas page of work program section #910

Merged
merged 5 commits into from
Jan 31, 2025
Merged

feat: restyled project ideas page of work program section #910

merged 5 commits into from
Jan 31, 2025

Conversation

Queen-codes
Copy link
Contributor

@Queen-codes Queen-codes commented Jan 23, 2025 •
edited by TimidRobot
Loading

Fixes

Description

  • adds button styling similar to legaldb
  • restyles page based on old legacy styling

Screenshots

127 0 0 1_5000_programs_project-ideas_

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested review from a team as code owners January 23, 2025 08:09
@Queen-codes Queen-codes requested review from TimidRobot, Shafiya-Heena and Dhruvi16 and removed request for a team January 23, 2025 08:09
@possumbilities
Copy link
Contributor

@Queen-codes It seems the sidebar type sizing for headings is incredibly broken, and the bullets have vanished in the content for bulleted items?

@Queen-codes
Copy link
Contributor Author

Hi @possumbilities,
Regarding the sidebar heading sizes, I did notice the issue. It's the default styling from Vocabulary, and I held off from making any local changes as I wanted to avoid making decisions without your write-up on better typographic handling (as discussed in our last 1:1 meeting). However, if it’s better to align it with how it currently looks on the main branch for now, I can go ahead and do that. Let me know what you think!

For the bullets, initially I thought they could be achieved by adding

li {
list-style-type: circle
}

but it didn't look the same due to the legacy styling being

.project-ideas .body .project-idea .column li:before {
  content: "\ea02";
  font-family: "Vocabulary Icons";
  display: inline-block;
  font-size: 0.375rem;
  color: rgb(176, 176, 176);
}

Would it make sense to try and replicate this old styling(especially since I'm not entirely sure how the legacy vocabulary icon worked), or do you think switching to a simpler list-style-type might be better?

@possumbilities
Copy link
Contributor

@Queen-codes I think for the bullets, the best thing to do is to fallback to what Vocabulary does natively, which you can see rendered here in the docs.

As for font sizing, waiting on the writeup makes sense.

@Queen-codes Queen-codes mentioned this pull request Jan 24, 2025
Open
39 tasks
TimidRobot
TimidRobot approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, thank you!

@TimidRobot TimidRobot linked an issue Jan 31, 2025 that may be closed by this pull request
[Feature] Restyle CC Open Source Work Programs Page #894
Closed
1 task
@TimidRobot TimidRobot merged commit 5e440e1 into creativecommons:vocab-refresh Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimidRobot TimidRobot TimidRobot approved these changes

@Shafiya-Heena Shafiya-Heena Awaiting requested review from Shafiya-Heena Shafiya-Heena is a code owner automatically assigned from creativecommons/technology

@Dhruvi16 Dhruvi16 Awaiting requested review from Dhruvi16 Dhruvi16 is a code owner automatically assigned from creativecommons/ct-cc-open-source-core-committers

Assignees

@TimidRobot TimidRobot

@possumbilities possumbilities

Labels
None yet
Projects
TimidRobot
Archived in project
possumbilities
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Restyle CC Open Source Work Programs Page
3 participants
@Queen-codes @possumbilities @TimidRobot